Skip to content

Conversation

@odolbeau
Copy link
Member

Avoid weird errors like Call to a member function sync() on null for example.

@odolbeau odolbeau force-pushed the ensure-storage-exists branch from 7880ce7 to f796585 Compare June 18, 2018 19:44
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR. Thank you

@Nyholm Nyholm merged commit 234a082 into php-translation:master Jun 26, 2018
*/
private $storageManager;

private function getStorage($configName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, we forgot the return statement. See #240

@odolbeau odolbeau deleted the ensure-storage-exists branch June 26, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants