[EditInPlace] Fix bad HTML generation when there is HTML in the translation

[damienalexandre]

An error could occur when using Edit In Place with HTML in the translations:

Uncaught DOMException: Failed to execute 'setAttribute' on 'Element': 'show-for-custom-md"' is not a valid attribute name.
    at c.mount (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:3:20706)
    at new c (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:3:12341)
    at c._initRegions (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:6:24008)
    at c.start (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:6:20300)
    at b.<anonymous> (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:6:14355)
    at b.a.dispatchEvent (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:4:24074)
    at b.edit (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:4:27817)
    at HTMLDivElement.<anonymous> (http://notarealwebsite.com:8000/bundles/translation/js/content-tools.min.js?9:4:29468)
c.mount @ content-tools.min.js?9:formatted:2749
c @ content-tools.min.js?9:formatted:2418
c._initRegions @ content-tools.min.js?9:formatted:6656
c.start @ content-tools.min.js?9:formatted:6508
(anonymous) @ content-tools.min.js?9:formatted:6251
a.dispatchEvent @ content-tools.min.js?9:formatted:4299
b.edit @ content-tools.min.js?9:formatted:4482
(anonymous) @ content-tools.min.js?9:formatted:4524

Is was caused by the Translator, as we transform the translation to wrap them in a x-trans HTML tag, and the translation is set as an attribute of that tag, the bundle was building invalid HTML.

This PR remove the ability to Edit In Place a translation where HTML has been put, and also add tests.

This PR fix the generated HTML output and adds tests.

[damienalexandre]

This is going to fix #141.

[rvanlaak]

Are we sure wo don't want contenttools to support certain html tags?

http://getcontenttools.com/demo

If so, it would be a pity that we can't support html translations. Disabling it for edit in place in that case is better as trying to support it.

[damienalexandre]

You are right, we support HTML translations (we try to), as shown in the documentation: https://php-translation.readthedocs.io/en/latest/symfony/edit-in-place.html#the-editor-toolbox-for-html

symfony-bundle/Resources/public/js/editInPlace.js

Lines 57 to 61 in 5955660

	editor.init('x-trans', 'data-key', function(domRegion) {
	// true = fixture (string of text)
	// false = classic HTML block
	return domRegion.dataset.key.split('.').pop() !== 'html';
	});

So the implementation is broken when the HTML contains attributes.

Just pushed another way to fix this that works with HTML translations! 👏 Thanks for your input @rvanlaak !

PR was updated

[Nyholm]

Thank you