Skip to content

Minor: Fix typo in locale description in a few commands #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bocharsky-bw merged 4 commits into from
Jun 25, 2019
Merged

Minor: Fix typo in locale description in a few commands #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4d1cfe
Fix locale description in a few commands
bocharsky-bw Mar 7, 2019
226b93a
Merge branch 'master' of github.com:php-translation/symfony-bundle in…
bocharsky-bw Jun 25, 2019
8fd27de
Split use statements
bocharsky-bw Jun 25, 2019
fac6efa
Remove unused namespace and split namespaces
bocharsky-bw Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Command/DeleteObsoleteCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
*/
class DeleteObsoleteCommand extends Command
{
use BundleTrait, StorageTrait;
use BundleTrait;
use StorageTrait;

protected static $defaultName = 'translation:delete-obsolete';

Expand Down Expand Up @@ -72,7 +73,7 @@ protected function configure()
->setName(self::$defaultName)
->setDescription('Delete all translations marked as obsolete.')
->addArgument('configuration', InputArgument::OPTIONAL, 'The configuration to use', 'default')
->addArgument('locale', InputArgument::OPTIONAL, 'The locale ot use. If omitted, we use all configured locales.', null)
->addArgument('locale', InputArgument::OPTIONAL, 'The locale to use. If omitted, we use all configured locales.', null)
->addOption('bundle', 'b', InputOption::VALUE_REQUIRED, 'The bundle you want remove translations from.')
;
}
Expand Down
4 changes: 2 additions & 2 deletions Command/DownloadCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
use Translation\Bundle\Service\CacheClearer;
use Translation\Bundle\Service\ConfigurationManager;
use Translation\Bundle\Service\StorageManager;
use Translation\Bundle\Model\Configuration;

/**
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*/
class DownloadCommand extends Command
{
use BundleTrait, StorageTrait;
use BundleTrait;
use StorageTrait;

protected static $defaultName = 'translation:download';

Expand Down
2 changes: 1 addition & 1 deletion Command/ExtractCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ protected function configure()
->setName(self::$defaultName)
->setDescription('Extract translations from source code.')
->addArgument('configuration', InputArgument::OPTIONAL, 'The configuration to use', 'default')
->addArgument('locale', InputArgument::OPTIONAL, 'The locale ot use. If omitted, we use all configured locales.', false)
->addArgument('locale', InputArgument::OPTIONAL, 'The locale to use. If omitted, we use all configured locales.', false)
->addOption('hide-errors', null, InputOption::VALUE_NONE, 'If we should print error or not')
->addOption('bundle', 'b', InputOption::VALUE_REQUIRED, 'The bundle you want extract translations from.')
;
Expand Down