Move Exception into getConfiguration method #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odolbeau
approved these changes
Dec 3, 2019
| $manager->addConfiguration('default', $correctConfiguration); | ||
|
|
||
| $this->assertNull($manager->getConfiguration('missing')); | ||
| $config = $manager->getConfiguration('missing'); |
|
|
||
| public function testGetConfigurationMissing(): void | ||
| { | ||
| $this->expectException(\InvalidArgumentException::class); |
Member
There was a problem hiding this comment.
Could you move those line just before $manager->getConfiguration('missing'); as it's where you expect the test to fail?
welcoMattic
approved these changes
Dec 3, 2019
ker0x
force-pushed
the
get-configuration-exception
branch
from
c0223ae to
4986c3c
Compare
Member
|
Perfect! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception on missing configuration was only thrown when using a command. This fix that by moving Exception directly into
getConfiguration()method which is also called inWebUIController