-
Notifications
You must be signed in to change notification settings - Fork 93
Add support for PHP 8 #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've opened a PR php-translation/symfony-storage#51 |
| count: 1 | ||
| path: Translator/TranslatorInterface.php | ||
| excludes_analyse: | ||
| - Translator/TranslatorInterface.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to manage this error
% make phpstan
2 ↵ ✹
Note: Using configuration file /project/phpstan.neon.dist.
49/49 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------
----------------------------------------------------------------------
Line Translator/TranslatorInterface.php
------
----------------------------------------------------------------------
31 Interface Translation\Bundle\Translator\TranslatorInterface
extends
unknown interface
Symfony\Component\Translation\TranslatorInterface.
bulb Learn more at
https://phpstan.org/user-guide/discovering-symbols
------
----------------------------------------------------------------------
--
-------------------------------------------------------------------------
Error
--
-------------------------------------------------------------------------
Error message "Interface
Translation\Bundle\Translator\TranslatorInterface extends unknown
interface Symfony\Component\Translation\TranslatorInterface."
cannot be
ignored, use excludes_analyse instead.
--
-------------------------------------------------------------------------
|
I've also open a PR to php-translation/extractor#157 |
|
Any advance on this PR ? |
|
Hi, is there any updates for this? Thanks! |
|
Hi, I'm sorry, I have not free time to work on PHP8 support PRs those days (major incident on a famous French hosting company) + coming deadline to finish symfony/symfony#38475. |
|
No worries, I know you are hard working for adding translations providers for Symfony. Keep up the good work! 💪 |
|
Thank you for working on this and sorry for the slow replies! Currently, this PR is blocked by php-translation/symfony-storage#51 and waiting for it to be merged first |
I don't know how to manage this error
```
% make phpstan
2 ↵ ✹
Note: Using configuration file /project/phpstan.neon.dist.
49/49 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------
----------------------------------------------------------------------
Line Translator/TranslatorInterface.php
------
----------------------------------------------------------------------
31 Interface Translation\Bundle\Translator\TranslatorInterface
extends
unknown interface
Symfony\Component\Translation\TranslatorInterface.
💡 Learn more at
https://phpstan.org/user-guide/discovering-symbols
------
----------------------------------------------------------------------
--
-------------------------------------------------------------------------
Error
--
-------------------------------------------------------------------------
Error message "Interface
Translation\Bundle\Translator\TranslatorInterface extends unknown
interface Symfony\Component\Translation\TranslatorInterface."
cannot be
ignored, use excludes_analyse instead.
--
-------------------------------------------------------------------------
```
|
There are some CI jobs that fail. But they are not related to this PR. Thank you for your work. |
PR for issue #423