Skip to content

Conversation

@lepiaf
Copy link
Contributor

@lepiaf lepiaf commented Dec 8, 2020

PR for issue #423

@lepiaf
Copy link
Contributor Author

lepiaf commented Dec 8, 2020

composer update ${COMPOSER_FLAGS} --prefer-dist --prefer-stable --no-interaction

Loading composer repositories with package information

Updating dependencies

Your requirements could not be resolved to an installable set of packages.

  Problem 1

    - php-translation/symfony-storage[dev-master, 2.1.0, ..., 2.2.0] require php ^7.2 -> your php version (8.0.0) does not satisfy that requirement.

    - php-translation/symfony-storage 2.2.x-dev is an alias of php-translation/symfony-storage dev-master and thus requires it to be installed too.

    - Root composer.json requires php-translation/symfony-storage ^2.1 -> satisfiable by php-translation/symfony-storage[2.1.0, 2.2.0, 2.2.x-dev (alias of dev-master)].

I've opened a PR php-translation/symfony-storage#51

count: 1
path: Translator/TranslatorInterface.php
excludes_analyse:
- Translator/TranslatorInterface.php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to manage this error

% make phpstan
2 ↵ ✹
Note: Using configuration file /project/phpstan.neon.dist.
 49/49 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------
----------------------------------------------------------------------
  Line   Translator/TranslatorInterface.php
 ------
----------------------------------------------------------------------
  31     Interface Translation\Bundle\Translator\TranslatorInterface
extends
         unknown interface
Symfony\Component\Translation\TranslatorInterface.
         bulb Learn more at
https://phpstan.org/user-guide/discovering-symbols
 ------
----------------------------------------------------------------------

 --
-------------------------------------------------------------------------
     Error
 --
-------------------------------------------------------------------------
     Error message "Interface
     Translation\Bundle\Translator\TranslatorInterface extends unknown
     interface Symfony\Component\Translation\TranslatorInterface."
cannot be
     ignored, use excludes_analyse instead.
 --
-------------------------------------------------------------------------

@lepiaf lepiaf marked this pull request as ready for review December 8, 2020 16:36
@lepiaf
Copy link
Contributor Author

lepiaf commented Dec 8, 2020

I've also open a PR to php-translation/extractor#157

@Ciloe
Copy link

Ciloe commented Feb 12, 2021

Any advance on this PR ?

@Kocal
Copy link
Contributor

Kocal commented Mar 16, 2021

Hi, is there any updates for this?

Thanks!

@welcoMattic
Copy link
Member

Hi, I'm sorry, I have not free time to work on PHP8 support PRs those days (major incident on a famous French hosting company) + coming deadline to finish symfony/symfony#38475.
May be @bocharsky-bw or @rvanlaak are available to review those PRs?

@Kocal
Copy link
Contributor

Kocal commented Mar 16, 2021

No worries, I know you are hard working for adding translations providers for Symfony. Keep up the good work! 💪

@bocharsky-bw
Copy link
Member

Thank you for working on this and sorry for the slow replies!

Currently, this PR is blocked by php-translation/symfony-storage#51 and waiting for it to be merged first

lepiaf and others added 4 commits March 26, 2021 17:55
I don't know how to manage this error

```
% make phpstan
2 ↵ ✹
Note: Using configuration file /project/phpstan.neon.dist.
 49/49 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------
----------------------------------------------------------------------
  Line   Translator/TranslatorInterface.php
 ------
----------------------------------------------------------------------
  31     Interface Translation\Bundle\Translator\TranslatorInterface
extends
         unknown interface
Symfony\Component\Translation\TranslatorInterface.
         💡 Learn more at
https://phpstan.org/user-guide/discovering-symbols
 ------
----------------------------------------------------------------------

 --
-------------------------------------------------------------------------
     Error
 --
-------------------------------------------------------------------------
     Error message "Interface
     Translation\Bundle\Translator\TranslatorInterface extends unknown
     interface Symfony\Component\Translation\TranslatorInterface."
cannot be
     ignored, use excludes_analyse instead.
 --
-------------------------------------------------------------------------
```
@Nyholm
Copy link
Member

Nyholm commented Mar 26, 2021

There are some CI jobs that fail. But they are not related to this PR.

Thank you for your work.

@Nyholm Nyholm merged commit b74f88e into php-translation:master Mar 26, 2021
@lepiaf lepiaf deleted the support-php8 branch March 26, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants