Skip to content

Add support for PHP 8 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Add support for PHP 8 #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6698752
Add support for PHP 8
lepiaf Dec 8, 2020
0b7ed33
Fix phpstan
lepiaf Dec 8, 2020
5dd4d23
Exclude Translator/TranslatorInterface.php from phpstan analysis
lepiaf Dec 8, 2020
dffc010
Increase lowest version
Nyholm Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,31 @@
}
],
"require": {
"php": "^7.2",
"symfony/framework-bundle": "^3.4 || ^4.3 || ^5.0",
"symfony/validator": "^3.4 || ^4.3 || ^5.0",
"symfony/translation": "^3.4 || ^4.3 || ^5.0",
"symfony/twig-bundle": "^3.4 || ^4.3 || ^5.0",
"symfony/finder": "^3.4 || ^4.3 || ^5.0",
"symfony/intl": "^3.4 || ^4.3 || ^5.0",
"php": "^7.2 || ^8.0",
"symfony/framework-bundle": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/validator": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/translation": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/twig-bundle": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/finder": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/intl": "^3.4.47 || ^4.4.20 || ^5.2.5",

"php-translation/symfony-storage": "^2.1",
"php-translation/extractor": "^2.0",
"nyholm/nsa": "^1.1",
"twig/twig": "^2.11 || ^3.0"
"twig/twig": "^2.14.4 || ^3.3"
},
"require-dev": {
"symfony/phpunit-bridge": "^5.2",
"bamarni/composer-bin-plugin": "^1.3",
"php-translation/translator": "^1.0",
"php-http/curl-client": "^1.7",
"php-http/message": "^1.6",
"php-http/curl-client": "^1.7 || ^2.0",
"php-http/message": "^1.11",
"php-http/message-factory": "^1.0.2",
"symfony/console": "^3.4 || ^4.3 || ^5.0",
"symfony/twig-bridge": "^3.4 || ^4.3 || ^5.0",
"symfony/asset": "^3.4 || ^4.3 || ^5.0",
"symfony/dependency-injection": "^3.4 || ^4.3 || ^5.0",
"symfony/web-profiler-bundle": "^3.4 || ^4.3 || ^5.0",
"symfony/console": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/twig-bridge": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/asset": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/dependency-injection": "^3.4.47 || ^4.4.20 || ^5.2.5",
"symfony/web-profiler-bundle": "^3.4.47 || ^4.4.20 || ^5.2.5",
"matthiasnoback/symfony-dependency-injection-test": "^4.1",
"matthiasnoback/symfony-config-test": "^4.1",
"nyholm/psr7": "^1.1",
Expand Down
2 changes: 2 additions & 0 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,3 +145,5 @@ parameters:
count: 2
path: Twig/TranslationExtension.php

excludes_analyse:
- Translator/TranslatorInterface.php
Copy link
Contributor Author

@lepiaf lepiaf Dec 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to manage this error

% make phpstan
2 ↵ ✹
Note: Using configuration file /project/phpstan.neon.dist.
 49/49 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------
----------------------------------------------------------------------
  Line   Translator/TranslatorInterface.php
 ------
----------------------------------------------------------------------
  31     Interface Translation\Bundle\Translator\TranslatorInterface
extends
         unknown interface
Symfony\Component\Translation\TranslatorInterface.
         bulb Learn more at
https://phpstan.org/user-guide/discovering-symbols
 ------
----------------------------------------------------------------------

 --
-------------------------------------------------------------------------
     Error
 --
-------------------------------------------------------------------------
     Error message "Interface
     Translation\Bundle\Translator\TranslatorInterface extends unknown
     interface Symfony\Component\Translation\TranslatorInterface."
cannot be
     ignored, use excludes_analyse instead.
 --
-------------------------------------------------------------------------