fix extractor parameters #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
welcoMattic
reviewed
May 25, 2021
welcoMattic
approved these changes
May 25, 2021
Member
welcoMattic
left a comment
welcoMattic
left a comment
There was a problem hiding this comment.
It's ok for me
WDYT @php-translation/deciders?
Nyholm
approved these changes
May 25, 2021
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
If this is the only place where we use $metadataFactory, then Im all 👍 for this change.
Member
|
PHPStan failure seems unrelated, I think we can merge this one :) |
Contributor
Author
|
Yes, PhpStorm shows me only this place |
Contributor
Author
|
@Nyholm @welcoMattic, when do You plan to merge this? |
Member
|
I can merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplify future and repair error with unused var $metadatafactory in extractor.yaml