Skip to content

Fix PHPUnit deprecations #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rvanlaak merged 1 commit into from
Jun 22, 2021
Merged

Fix PHPUnit deprecations #447

rvanlaak merged 1 commit into from
Jun 22, 2021

Conversation

@bocharsky-bw
Copy link
Member

@bocharsky-bw bocharsky-bw commented Jun 18, 2021

assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

rvanlaak
rvanlaak approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvanlaak rvanlaak merged commit d7aba90 into php-translation:master Jun 22, 2021
@bocharsky-bw bocharsky-bw deleted the fix-phpunit branch June 23, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@rvanlaak rvanlaak rvanlaak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bocharsky-bw @welcoMattic @rvanlaak