Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 32d5b8d

Browse files
committed
Fix ChromeDriver declaration to match the parent class
1 parent 21b62c4 commit 32d5b8d

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lib/Chrome/ChromeDriver.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,16 @@ public static function create(
8282
*
8383
* @param string $session_id The existing session id
8484
* @param string $selenium_server_url The url of the remote Selenium WebDriver server
85-
*
85+
* @param int|null $connection_timeout_in_ms Set timeout for the connect phase to remote Selenium WebDriver server
86+
* @param int|null $request_timeout_in_ms Set the maximum time of a request to remote Selenium WebDriver server
8687
* @throws WebDriverException
8788
* @return RemoteWebDriver|void
8889
*/
8990
public static function createBySessionID(
9091
$session_id,
91-
$selenium_server_url = 'http://localhost:4444/wd/hub'
92+
$selenium_server_url = 'http://localhost:4444/wd/hub',
93+
$connection_timeout_in_ms = null,
94+
$request_timeout_in_ms = null
9295
) {
9396
throw new WebDriverException('Please use ChromeDriver::start() instead.');
9497
}

0 commit comments

Comments
 (0)