Wrong information in comment at example #1 (Implicit Commit Example)

[abdelrahman-gado]

From manual page: https://php.net/pdo.transactions

---

in the Example 1 Implicit Commit Example

<?php
$pdo->beginTransaction();
$pdo->exec("INSERT INTO users (name) VALUES ('Rasmus')");
$pdo->exec("CREATE TABLE test (id INT PRIMARY KEY)"); // Implicit COMMIT occurs here
$pdo->rollBack(); // This will NOT undo the INSERT/CREATE for MySQL or Oracle
?>

The comment in the last line $pdo->rollback(); explains that we cannot undo the INSERT and this is wrong.
we can undo the INSERT but we cannot undo the create or drop (DDL) statements, So it should be like this

<?php
$pdo->beginTransaction();
$pdo->exec("INSERT INTO users (name) VALUES ('Rasmus')");
$pdo->exec("CREATE TABLE test (id INT PRIMARY KEY)"); // Implicit COMMIT occurs here
$pdo->rollBack(); // This will NOT undo the DROP/CREATE for MySQL or Oracle
?>

[kamil-tekiela]

The comment in the last line $pdo->rollback(); explains that we cannot undo the INSERT and this is wrong.
we can undo the INSERT but we cannot undo the create or drop (DDL) statements

It's not wrong. We cannot undo THIS INSERT because it has been implicitly committed by the DDL. If you think it can be written more clearly, feel free to submit a PR to improve the wording, but as it stands, this issue report is invalid, so I am going to close it.