-
Notifications
You must be signed in to change notification settings - Fork 831
Remove PHP 5 specific documentation #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit removes following extensions as they appear to not provide support for PHP 7.0. apc apd bbcode bcompiler cairo chdb crack cyrus fam (PHP4?) fribidi gupnp haru htscanner hwapi id3 inclued kadm5 ktaglib lapack libevent mcve ming mnogosearch msession net-gopher newt nis oggvorbis parsekit phdfs rpmreader (PHP4?) runkit sam (PHP4?) sca scream session_pgsql stats swish vpopmail (PHP4?) win32ps
This is done separately for diff clarify, previous commit only removes lines and here's where the adjustments start. There are still errors related to runkit extension but this will be handled separately.
Manual now builds fine, yay!
|
Nice. 🥇 Be sure to grab the "PHP 5" archives and stow them somewhere safe before applying this. |
|
@salathe, see php/web-php#341. Could you put the PHP 5 archives to http://doc.php.net/archives/? |
|
@cmb69 the PHP 5 archives are now in Git (php/web-doc@aa24ddb) and available at http://doc.php.net/archives/php5/ |
|
WIP:
Done \o/ Thank you very much @Sobak for doing this work, and thanks @salathe for moving the archived documentation to the repo! |
|
@cmb69 Hi Christoph :) I'm very thankful that you pushed the work forward. Sadly, I'm totally swamped due to my job and it's unlikely to change very soon so as much as I'd like to help, I fail to motivate in my free time. I just want to point out that this is not a complete removal. There are still changelogs for newer PHP 5.x versions left and probably a ton of inline mentions. However, now that the effort begun on the live repo, I'll at least try to contribute some tiny bits from time to time. Kudos for all the work you do! |
This is @Sobak's previous work; I just rebased onto current master and fixed conflicts. Since these are quite comprehensive changes, review is very welcome.