Remove PHP 5 from mysqli, PDO_MySQL and mysqlnd #253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
force-pushed
the
Remove-PHP-5-specific-notes
branch
from
c673f45 to
0c77138
Compare
afilina
requested changes
Jan 7, 2021
Contributor
afilina
left a comment
afilina
left a comment
There was a problem hiding this comment.
Besides one nitpicky suggestions, LGTM.
Co-authored-by: Anna Filina <afilina@gmail.com>
cmb69
reviewed
Jan 7, 2021
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thanks! Overall a very nice cleanup. Please check my review comments.
| <term><constant>MYSQLI_OPT_SSL_VERIFY_SERVER_CERT</constant></term> | ||
| <listitem> | ||
| <para> | ||
| Available since PHP 5.3.0. (MySQL 5.1.10 and up) |
Member
There was a problem hiding this comment.
Sadly, PHP 7.0.0 is supposed to work with MySQL >= 4.1.13 and MySQL >= 5.0.7, so please keep the relevant info for MySQL.
Member
Author
There was a problem hiding this comment.
I'll review it over the weekend and add it back in. Thanks!
Member
Author
There was a problem hiding this comment.
Added the note + 2 other back in.
This reverts commit 0b8f249.
Contributor
|
Checked the new commits. Looks like all suggestions were addressed. |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure what to do about https://www.php.net/manual/en/mysqli.installation.php