digit.xml: add tags, amend example#3595
Merged
Merged
Conversation
> In this case the value is c-'A'+10 for latin lettera A-Z and > In this case the value is ch-'a'+10 — it looks like this text was copied aimlessly from the comment of the ICU source code file: https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/unicode/uchar.h#L4252 And these sentences, IMHO, do not make sense in the context of the PHP method description, but only `u_digit` definition: https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/uchar.cpp#L452
mmalferov
changed the title
lacatoire
approved these changes
Feb 2, 2026
Member
|
LGTM Thanks @mmalferov |
Member
|
Thanks! |
jordikroon
pushed a commit
to Narkunan/doc-en
that referenced
this pull request
May 17, 2026
* digit.xml: add tags, amend example, del meaningless sentences > In this case the value is c-'A'+10 for latin lettera A-Z and > In this case the value is ch-'a'+10 — it looks like this text was copied aimlessly from the comment of the ICU source code file: https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/unicode/uchar.h#L4252 And these sentences, IMHO, do not make sense in the context of the PHP method description, but only `u_digit` definition: https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/uchar.cpp#L452 * digit.xml: restore `ch - 'A' + 10` but replace `ch` to `codepoint`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the description of the method,
and
— it looks like this text was copied aimlessly from the comment of the ICU source code file:
source/common/unicode/uchar.h
And these sentences, IMHO, do not make sense in the context of the PHP method description, but only
u_digitdefinition:source/common/uchar.cpp