Skip to content

Conversation

@lacatoire
Copy link
Contributor

This PR fixes the xdiff_string_rabdiff() documentation, which incorrectly displayed the function name and description for xdiff_string_bdiff().

Changes:

  • Corrected to use xdiff_string_rabdiff.
  • Updated description to reflect the Rabin’s polynomial fingerprinting algorithm.
  • Added example and “See also” links for related functions.

Issue here #4987

lacatoire and others added 3 commits November 18, 2025 09:56
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
lacatoire and others added 3 commits November 18, 2025 15:00
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
@kamil-tekiela kamil-tekiela merged commit 1987020 into php:master Nov 18, 2025
2 checks passed
&reftitle.description;
<methodsynopsis>
<type>string</type><methodname>xdiff_string_bdiff</methodname>
<type>string|false</type><methodname>xdiff_string_rabdiff</methodname>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how union types are tagged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I didn't see that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants