Open
Conversation
Remove deprecated -z/--zend-extension command-line option documentation. Document new --ini=diff feature for PHP 8.5.0+ and add changelog entry for cli_get_process_title() E_WARNING behavior change in 8.5.0.
ca4a63e to
7fcbaf9
Compare
Updated XML documentation to use simpara (simple paragraph) tags instead of para tags within the note element for the --ini=diff option. This provides more semantically appropriate markup for brief, single-paragraph content.
Girgias
reviewed
Jan 30, 2026
Comment on lines
+64
to
+65
| <function>cli_get_process_title</function> will now return an <constant>E_WARNING</constant> | ||
| if the process title is too long to be retrieved. |
Member
There was a problem hiding this comment.
Return an E_WARNING? Did you mean to say "will now emit an E_WARNING"?
Member
|
Thanks for the CLI changes @jordikroon ! The -z removal and --ini=diff look good. But i think there might be an error in the changelog entry, the "too long" check was added to set_ps_title(), not get_ps_title(). Should this be a changelog for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to silently remove the -z feature since the
-zoption as it was non-functional. If we wish to document I'd like to have suggestions of where to put.