Skip to content

Improve Docker build process, remove --disable-segfault-error#5552

Merged
cweiske merged 2 commits into
php:masterfrom
jordikroon:build/docker-buster
May 12, 2026
Merged

Improve Docker build process, remove --disable-segfault-error#5552
cweiske merged 2 commits into
php:masterfrom
jordikroon:build/docker-buster

Conversation

@jordikroon
Copy link
Copy Markdown
Member

php/doc-base#285 removed --disable-segfault-error. Dockerfile was still passing this argument resulting in a warning. Thus we should remove it as well.

Also altered Makefile to write a file hash to .docker/built instead. If we don't this warning will still pop unless we manually remove that file.

@jordikroon jordikroon requested a review from kamil-tekiela May 12, 2026 16:52
@kamil-tekiela
Copy link
Copy Markdown
Member

I'm not familiar with Docker, so I can't review it.

@jordikroon jordikroon requested review from afilina and cweiske and removed request for kamil-tekiela May 12, 2026 18:25
@jordikroon
Copy link
Copy Markdown
Member Author

I'm not familiar with Docker, so I can't review it.

No worries. Much appreciated to let me know.

@cweiske
Copy link
Copy Markdown
Contributor

cweiske commented May 12, 2026

The CMD change is fine, but I don't like the Makefile change. make lets you add file names as dependencies to tasks, and when the file changes, it will re-run the task. Adding the Dockerfile as dependency should fix that without manually comparing hashes.

@jordikroon
Copy link
Copy Markdown
Member Author

Thank you for checking @cweiske. I didn't know it was that simple. But it seems to do the trick.

@cweiske cweiske merged commit 91fd40c into php:master May 12, 2026
2 checks passed
@cweiske
Copy link
Copy Markdown
Contributor

cweiske commented May 12, 2026

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants