Skip to content

Fix copy-pasted descriptions referencing the wrong function#5576

Merged
jordikroon merged 7 commits into
php:masterfrom
lacatoire:fix/copy-paste-descriptions
May 25, 2026
Merged

Fix copy-pasted descriptions referencing the wrong function#5576
jordikroon merged 7 commits into
php:masterfrom
lacatoire:fix/copy-paste-descriptions

Conversation

@lacatoire
Copy link
Copy Markdown
Member

Several reference pages had a refpurpose, return value or example title copy-pasted from a sibling function, so they pointed to the wrong function or concept (e.g. Event::WRITE described as ready for reading, eio_chown documented as changing permissions instead of ownership).

Copy link
Copy Markdown
Member

@jordikroon jordikroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few small maintenance nits.

Comment thread reference/zmq/zmqdevice/settimercallback.xml Outdated
Comment thread reference/zmq/zmqdevice/settimercallback.xml Outdated
Comment thread reference/zmq/zmqdevice/settimercallback.xml Outdated
Comment thread reference/zmq/zmqdevice/settimercallback.xml Outdated
Comment thread reference/event/event.xml Outdated
Comment thread reference/event/event.xml Outdated
lacatoire and others added 6 commits May 23, 2026 22:54
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
@jordikroon jordikroon merged commit 184764a into php:master May 25, 2026
2 checks passed
@lacatoire lacatoire deleted the fix/copy-paste-descriptions branch May 25, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants