Nits: codespell typos in standard (bundled) extensions#5586
Merged
Conversation
Run codespell across documentation for extensions still bundled with php-src, and apply the suggestions. Scope deliberately limited to extensions in our direct control, leaving PECL/third-party extensions for a separate pass.
…ing" - type-juggling.xml: revert "convertable" -> "convertible" (both spellings are valid per @kamil-tekiela) and the related para -> simpara conversion - getimagesize.xml: use "corresponding" instead of "correspondent"
- set-strength.xml: replace the broken textual reference "Ignoring Punctuation" with a real link to Collator::ALTERNATE_HANDLING, which documents the mechanism for ignoring punctuation during collation; this also removes the trailing space @kamil-tekiela pointed out - language-snippets.ent: revert the gd.changlog.t1lib -> gd.changelog.t1lib rename since this entity is not referenced anywhere in the repo, so the codespell fix had no benefit
kamil-tekiela
requested changes
May 28, 2026
Member
kamil-tekiela
left a comment
kamil-tekiela
left a comment
There was a problem hiding this comment.
Could you please drop the reference/intl/collator/set-strength.xml file from this PR? I don't like the whole thing. The content is plagiarized from https://github.com/unicode-org/icu/blob/main/docs/userguide/collation/concepts.md and makes no sense with the missing bits. It's just putting lipstick on a pig. The whole documentation needs to be rewritten from scratch.
Per @kamil-tekiela's review, the file is plagiarized from ICU and needs to be rewritten from scratch rather than patched here. Reverting it to its current master state so this PR stays scoped to codespell fixes.
kamil-tekiela
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran codespell across documentation for extensions still bundled with php-src, and applied the suggestions (56 files, 112 lines). Scope intentionally limited to bundled extensions so the PR stays small and reviewable.
Happy to drop any file that conflicts with an in-flight PR. Cross-checked against currently open PRs and excluded
in-array.xmlto avoid overlap with #5519.