exit() doesn't stop the worker script

[dunglas]

What happened?

A call to exit() should stop and restart the worker script, but this isn't currently the case.

With a simple Symfony controller like this, $i should always be 0, but it is actually incrementing.

namespace App\Controller;

use Symfony\Component\Routing\Attribute\Route;

class HomeController
{
    #[Route('/')]
    public function __invoke(): string
    {
        static $i = 0;
        $i++;
        echo 'Hello '.$i;
        exit(0);
    }
}

This is likely the root cause of #1553, dunglas/symfony-docker#792, and dunglas/symfony-docker#773

Maybe @AlliBalliBab,a you have a clue of what's going on?

[AlliBalliBaba]

I don't think exit has ever stopped the worker script.

It's also the reason why features like Symphony's dd() would work with FrankenPHP while being broken with Swoole or Roadrunner (at least that was the case with Laravel Octane when testing a while ago)

[dunglas]

Actually, this fixes dd() 😅

[AlliBalliBaba]

Hmm kind if weird that it would work in Laravel, but not in Symfony. I'll have to do some testing...

[dunglas]

I don't see how restarting the worker when exiting could break Laravel either

[AlliBalliBaba]

Yeah I tested a bit and it generally seems fine with the big frameworks. It's probably good to have an option to force a clean worker script exit. I guess it's just hard to predict how commonly exit is used in other cases.

Should be fine if it's documented and tested to work that way.