Incorrect version tagging in deb/rpm packages.

[henderkes]

What happened?

However, the version info is correctly embedded in the binary.

FrankenPHP v1.6.2 PHP 8.4.7 Caddy v2.10.0 h1:fonubSaQKF1YANl8TXqGcn4IbIRUDdfAkpcsfI/vX5U=

Build Type

Custom (tell us more in the description)

Worker Mode

Yes

Operating System

GNU/Linux

CPU Architecture

x86_64

PHP configuration

a

Relevant log output

[henderkes]

Okay that's really weird...

[m@M-TH frankenphp]$ export FRANKENPHP_VERSION=1.6.2
[m@M-TH frankenphp]$ PHP_EXTENSIONS=iconv PHP_EXTENSION_LIBS="libacl" ./build-static.sh && ./build-packages.sh
->
+ fpm -s dir -t rpm -n frankenphp -v 1.6.2 --config-files /etc/frankenphp/Caddyfile --config-files /etc/frankenphp/php.ini --depends 'libc.so.6(GLIBC_2.34)(64bit)' --depends 'libstdc++.so.6(CXXABI_1.3.13)(64bit)' --before-install ../package/rhel/preinstall.sh --after-install ../package/rhel/postinstall.sh --before-remove ../package/rhel/preuninstall.sh --after-remove ../package/rhel/postuninstall.sh --iteration 1 --rpm-user frankenphp --rpm-group frankenphp frankenphp-linux-x86_64=/usr/bin/frankenphp ../package/rhel/frankenphp.service=/usr/lib/systemd/system/frankenphp.service ../package/Caddyfile=/etc/frankenphp/Caddyfile ../package/content/=/usr/share/frankenphp ../package/etc/php.ini=/etc/frankenphp/php.ini ../package/empty/=/etc/frankenphp/php.d ../package/empty/=/usr/lib/frankenphp/modules ../package/empty/=/var/lib/frankenphp
Created package {:path=>"frankenphp-1.6.2-1.x86_64.rpm"}
++ ldd -v frankenphp-linux-x86_64
-- snip --
+ cxxabi_version=1.3.13
+ fpm -s dir -t deb -n frankenphp -v 1.6.2 --config-files /etc/frankenphp/Caddyfile --config-files /etc/frankenphp/php.ini --depends 'libc6 (>= 2.34)' --depends 'libstdc++6 (>= 1.3.13)' --after-install ../package/debian/postinst.sh --before-remove ../package/debian/prerm.sh --after-remove ../package/debian/postrm.sh --iteration 1 --deb-user frankenphp --deb-group frankenphp frankenphp-linux-x86_64=/usr/bin/frankenphp ../package/debian/frankenphp.service=/usr/lib/systemd/system/frankenphp.service ../package/Caddyfile=/etc/frankenphp/Caddyfile ../package/content/=/usr/share/frankenphp ../package/etc/php.ini=/etc/frankenphp/php.ini ../package/empty/=/etc/frankenphp/php.d ../package/empty/=/usr/lib/frankenphp/modules ../package/empty/=/var/lib/frankenphp
Debian packaging tools generally labels all files in /etc as config files, as mandated by policy, so fpm defaults to this behavior for deb packages. You can disable this default behavior with --deb-no-default-config-files flag {:level=>:warn}
Created package {:path=>"frankenphp_1.6.2-1_amd64.deb"}
+ '[' 1 -eq 0 ']'
+ '[' 1 -eq 0 ']'
+ cd ..
[m@M-TH frankenphp]$

[henderkes]

relevant run:
https://github.com/dunglas/frankenphp/actions/runs/15206125625/job/42769570695

#26 1668.0 + '[' '!' -f dist/frankenphp-linux-x86_64 ']'
#26 1668.0 Warning: FRANKENPHP_VERSION must be set to X.Y.Z (e.g. 1.5.1), got 'v1.6.2'
#26 1668.0 Falling back to non-release version 0.0.0
#26 1668.0 + '[' -z v1.6.2 ']'
#26 1668.0 + '[' -d .git/ ']'
#26 1668.0 + [[ ! v1.6.2 =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]
#26 1668.0 + echo 'Warning: FRANKENPHP_VERSION must be set to X.Y.Z (e.g. 1.5.1), got '\''v1.6.2'\'''
#26 1668.0 + echo 'Falling back to non-release version 0.0.0'

[henderkes]

Looks like it's a peculiarity of the Github CI runners where .git doesn't exist anymore after a checkout?
Cannot reproduce it locally.