Inconsistent file naming: watcher-skip.go vs underscore convention

[pawelkudzia]

Hi, I noticed that the file watcher-skip.go uses a hyphen (-) in its name, while other files in the project follow the underscore (_) convention, such as watcher_test.go and memory_linux.go.

Is there a specific reason for this? Would it make sense to align the naming with the existing convention for better consistency?

[henderkes]

All the -skip files are suffixed that way. watcher-skip, mercure-skip, br-skip and hotreload-skip.

Edit: because you mentioned memory_linux and watcher_test, those are Go's conventions for platform specific files and tests. E.g. memory_linux is ignored on macOS or Windows, watcher_test is ignored when not testing.

[pawelkudzia]

@henderkes Ok, so the -skip suffix is just a naming convention, not a mistake. It could just as well be something like cool_feature.go and cool_feature-skip.go where in cool_feature-skip.go the feature is disabled.

I wasn’t familiar with Go’s build tags before, so I didn’t realize you can use tags to exclude files from the build. Now it makes sense, although at first glance the - in the filename can look like a typo.

Thank you.