Skip to content

update docs for first-time contributor#1368

Merged
dunglas merged 1 commit intophp:mainfrom
IndraGunawan:update-contributing-docs
Feb 17, 2025
Merged

update docs for first-time contributor#1368
dunglas merged 1 commit intophp:mainfrom
IndraGunawan:update-contributing-docs

Conversation

@IndraGunawan
Copy link
Copy Markdown
Contributor

updating contibuting.md to make things work on the first try

Comment thread dev.Dockerfile
cmake --install build
cmake --install build && \
cp build/libwatcher-c.so /usr/local/lib/libwatcher-c.so && \
ldconfig
Copy link
Copy Markdown
Contributor Author

@IndraGunawan IndraGunawan Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following this comment #1156 (comment)

@dunglas
Copy link
Copy Markdown
Member

dunglas commented Feb 12, 2025

Good catches!

@dunglas dunglas merged commit 233753c into php:main Feb 17, 2025
@dunglas
Copy link
Copy Markdown
Member

dunglas commented Feb 17, 2025

Thanks!

@IndraGunawan IndraGunawan deleted the update-contributing-docs branch March 25, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants