Skip to content

Avoid extra string allocation in get_full_env() #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 2 commits into from
Feb 18, 2025
Merged

Avoid extra string allocation in get_full_env() #1382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa35004
Avoid extra string allocation in get_full_env()
ndossche Feb 17, 2025
8bc27c4
Use add_assoc_str_ex
ndossche Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions frankenphp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,11 @@ PHPAPI void get_full_env(zval *track_vars_array) {
go_string key = full_env.r0[i * 2];
go_string val = full_env.r0[i * 2 + 1];

// create PHP strings for key and value
zend_string *key_str = zend_string_init(key.data, key.len, 0);
// create PHP string for the value
zend_string *val_str = zend_string_init(val.data, val.len, 0);

// add to the associative array
add_assoc_str(track_vars_array, ZSTR_VAL(key_str), val_str);

// release the key string
zend_string_release(key_str);
add_assoc_str_ex(track_vars_array, key.data, key.len, val_str);
}
}

Expand Down
Loading