Skip to content

fix: use local Go toolchain#1546

Merged
dunglas merged 11 commits intomainfrom
fix/gotoolchain
May 11, 2025
Merged

fix: use local Go toolchain#1546
dunglas merged 11 commits intomainfrom
fix/gotoolchain

Conversation

@dunglas
Copy link
Copy Markdown
Member

@dunglas dunglas commented May 8, 2025

Companion PR to #1545

Comment thread dev-alpine.Dockerfile Outdated
Comment thread dev.Dockerfile Outdated
@AlliBalliBaba
Copy link
Copy Markdown
Contributor

Is go mod graph | awk '{if ($1 !~ "@") print $2}' | xargs go get just there for build performance or also to ensure fresh library versions?

dunglas and others added 2 commits May 9, 2025 01:02
Co-authored-by: Alexander Stecher <45872305+AlliBalliBaba@users.noreply.github.com>
Co-authored-by: Alexander Stecher <45872305+AlliBalliBaba@users.noreply.github.com>
@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented May 8, 2025

Just for build performance.

@AlliBalliBaba AlliBalliBaba mentioned this pull request May 9, 2025
@AlliBalliBaba
Copy link
Copy Markdown
Contributor

I think it would also be fine to just remove that line and let go.mod handle the dependencies, I started a new pipeline in #1545 to compare how much slower it makes the builds.

@AlliBalliBaba
Copy link
Copy Markdown
Contributor

Seems to not make much difference, maybe even a bit slower with the manual go get ..., hard to accurately compare though

without go get with go get
3:35 3:35
3:28 4:00
4:28 4:53
3:33 4:56

@dunglas dunglas force-pushed the fix/gotoolchain branch 3 times, most recently from da912e9 to 1cc862b Compare May 11, 2025 06:07
@dunglas dunglas force-pushed the fix/gotoolchain branch from 1cc862b to c1e48f7 Compare May 11, 2025 07:17
@dunglas dunglas force-pushed the fix/gotoolchain branch from 6b1dfdd to 1900dc1 Compare May 11, 2025 10:15
@robsontenorio
Copy link
Copy Markdown

@dunglas the build docker image pipeline has failed.

@dunglas dunglas merged commit 0d12a51 into main May 11, 2025
58 checks passed
@dunglas dunglas deleted the fix/gotoolchain branch May 11, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants