feat(extgen): multiple improvements on C generated code#1698
Merged
feat(extgen): multiple improvements on C generated code#1698
Conversation
dunglas
reviewed
Jun 27, 2025
alexandre-daubois
force-pushed
the
extgen-imp
branch
2 times, most recently
from
8d1e4e8 to
579e083
Compare
alexandre-daubois
force-pushed
the
extgen-imp
branch
from
579e083 to
2819c9b
Compare
dunglas
approved these changes
Jun 27, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings some improvements to the generated C code of the extension generator. Here are the changes:
class_namefrom object structure, it is unusedget_methodUncaught Error: Trying to clone an uncloneable object of class MySuperClass. We could implement the clone fairly easily I guess, but let's keep it simple for now