fix: compare the correct versions in docker pipeline#1745
Merged
Conversation
dunglas
approved these changes
Jul 15, 2025
Member
|
Thanks |
|
Thanks! looks like its working, although I now have to go an learn how the hell a hash/poundsign can truncate a string... thats crazy skills right there! haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @PhilETaylor correctly noticed in #1742 the docker version used to compare latest images in the pipeline has a leading 'v'.
This PR removes the 'v' and prevents the docker build job from being triggered unnecessarily every night even when there is no new version available upstream.