feat(static): use v3 StaticPHP for build-static.sh#2399
Conversation
henderkes
left a comment
There was a problem hiding this comment.
I actually planned on switching FrankenPHP over to use craft with environment variables instead. The build-static scripts and Dockerfiles are a bit of a no-longer-required (thanks to zig) abomination.
The best approach I think is to use vendor mode to directly extend an SPC frankenphp build command, which can handle both build-static.sh and post-build steps including that in Dockerfile. Simply using the current craft.yml seems insufficient. for now. In addition, there is an issue supporting Alpine Linux. I'm not sure if we should give up on it, but I haven't tested whether v3 works properly on Alpine and Docker yet. |
|
Frankenphp doesn't need anything that isn't already available in staticphp. The craft.yml file (with env vars injected) can already do everything. |
No description provided.