Skip to content

feat(static): use v3 StaticPHP for build-static.sh#2399

Draft
crazywhalecc wants to merge 1 commit into
php:mainfrom
crazywhalecc:refactor/v3-spc
Draft

feat(static): use v3 StaticPHP for build-static.sh#2399
crazywhalecc wants to merge 1 commit into
php:mainfrom
crazywhalecc:refactor/v3-spc

Conversation

@crazywhalecc
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually planned on switching FrankenPHP over to use craft with environment variables instead. The build-static scripts and Dockerfiles are a bit of a no-longer-required (thanks to zig) abomination.

@crazywhalecc
Copy link
Copy Markdown
Contributor Author

crazywhalecc commented May 9, 2026

I actually planned on switching FrankenPHP over to use craft with environment variables instead. The build-static scripts and Dockerfiles are a bit of a no-longer-required (thanks to zig) abomination.

The best approach I think is to use vendor mode to directly extend an SPC frankenphp build command, which can handle both build-static.sh and post-build steps including that in Dockerfile. Simply using the current craft.yml seems insufficient. for now.

In addition, there is an issue supporting Alpine Linux. I'm not sure if we should give up on it, but I haven't tested whether v3 works properly on Alpine and Docker yet.

@henderkes
Copy link
Copy Markdown
Contributor

Frankenphp doesn't need anything that isn't already available in staticphp. The craft.yml file (with env vars injected) can already do everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants