ci: attest release artifacts with actions/attest#2418
Merged
Conversation
Generate SLSA build-provenance attestations for every released artifact via actions/attest@v4 (the recommended action that auto-fills the SLSA v1 predicate). - static.yaml: switch the three existing attest-build-provenance calls to actions/attest and add the artifact-metadata:write permission required by v4. - windows.yaml: attest the released frankenphp-windows-x86_64.zip. - docker.yaml: attest each pushed manifest list (builder + runner per variant) by digest, pushing the attestation to the registry.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds SLSA build-provenance attestations to release artifacts produced by the static, Windows, and Docker workflows by switching from actions/attest-build-provenance@v4 to the more generic actions/attest@v4, and attaching attestations to pushed Docker manifest lists by digest.
Changes:
- Replace
actions/attest-build-provenance@v4withactions/attest@v4in static builds and add a newartifact-metadata: writepermission to all attesting jobs. - Attest the Windows release zip (
frankenphp-windows-x86_64.zip) when a release ref is set. - In the Docker workflow, capture the manifest digest for each pushed image and create a registry-attached attestation via
actions/attest@v4withpush-to-registry: true.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/static.yaml | Switches three attestation steps to actions/attest@v4 and grants the new artifact-metadata: write permission. |
| .github/workflows/windows.yaml | Adds id-token/attestations/artifact-metadata permissions and an attestation step for the released Windows zip. |
| .github/workflows/docker.yaml | Captures image name + digest from imagetools inspect and attests each pushed manifest with push-to-registry: true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate SLSA build-provenance attestations for every released artifact via
actions/attest@v4(the recommended action that auto-fills the SLSA v1 predicate when no custom predicate is supplied).static.yaml: switch the three existingactions/attest-build-provenance@v4calls toactions/attest@v4and add the newartifact-metadata: writepermission required by v4.windows.yaml: attest the releasedfrankenphp-windows-x86_64.zip.docker.yaml: attest each pushed manifest list (builder + runner per variant) by digest, pushing the attestation to the registry alongside the image so consumers can rungh attestation verify oci://docker.io/dunglas/frankenphp@sha256:... --owner php.Verifying after merge