fix ext-parallel crashes#2438
Open
henderkes wants to merge 3 commits into
Open
Conversation
henderkes
requested review from
AlliBalliBaba and
dunglas
and removed request for
dunglas
Member
|
Unfortunately, write protection on main is not possible anymore because our new automated release GHA workflow creates a commit, and we cannot make an exception for bots (we can for "normal" users). That's a pity. |
Contributor
Author
|
Unfortunate. To be honest it's the first time in about 7 years this happened to me, I usually use cli for my git operations. |
Member
|
This will not happen again, I found a better solution, implemented in #2439 |
Contributor
Author
|
For a second here I thought you were talking about the thread_index fix 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dunglas I accidentally fumbled and had fix/parallel set to track origin/main, then used goland to push which just went with it, so the broken clang-format commit directly landed in main. Perhaps you could set up write protection on main so that cannot even happen?
Anyway, this fixes #2339