Skip to content

ci: Prevent build-static.sh build with custom libs failure#642

Merged
dunglas merged 4 commits intophp:mainfrom
crazywhalecc:patch-1
Mar 11, 2024
Merged

ci: Prevent build-static.sh build with custom libs failure#642
dunglas merged 4 commits intophp:mainfrom
crazywhalecc:patch-1

Conversation

@crazywhalecc
Copy link
Copy Markdown
Contributor

@crazywhalecc crazywhalecc changed the title Prevent build-static.sh build with custom libs failure ci: Prevent build-static.sh build with custom libs failure Mar 10, 2024
Copy link
Copy Markdown
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just left a minor comment.

@dunglas
Copy link
Copy Markdown
Member

dunglas commented Mar 10, 2024

By the way, now that there is a lock file for the downloaded libraries, couldn't we put the archives and even the build cache in the cache of GitHub Actions to speed up the CI?

@crazywhalecc
Copy link
Copy Markdown
Contributor Author

crazywhalecc commented Mar 10, 2024

By the way, now that there is a lock file for the downloaded libraries, couldn't we put the archives and even the build cache in the cache of GitHub Actions to speed up the CI?

Of course we can store download sources into gha cache. (uses: actions/cache@v3) (already used in tests)

But I do not recommend caching buildroot. For example, sometimes we cache a certain library built with the most features (such as curl with nghttp2), and the next time it is compiled without nghttp2, the symbol will not found. Only some libraries that do not depend on any other lib or do not contain optional features in the dep tree can be cached.

In fact, I had plans to directly compile and distribute pkg-config, zlib and other libraries to static-php.dev, but these independent libraries will not take up too much compilation time.

@dunglas dunglas merged commit 83aaa09 into php:main Mar 11, 2024
@dunglas
Copy link
Copy Markdown
Member

dunglas commented Mar 11, 2024

Thank you very much @crazywhalecc!

@crazywhalecc crazywhalecc deleted the patch-1 branch March 11, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running ./build-static.sh on a laravel project, fetch error

2 participants