Skip to content

More Windows CI fixes#48

Merged
rlerdorf merged 3 commits intomasterfrom
ci/windows-improvements
Apr 5, 2026
Merged

More Windows CI fixes#48
rlerdorf merged 3 commits intomasterfrom
ci/windows-improvements

Conversation

@rlerdorf
Copy link
Copy Markdown
Member

@rlerdorf rlerdorf commented Apr 5, 2026

CI: Add NTS builds, DLL artifacts, and fix tools typo

Supersedes #39

Changes

  • Add NTS to Windows matrix: Test both thread-safe and non-thread-safe builds (was TS only)
  • Upload built DLLs as artifacts: Each Windows build uploads php_mailparse.dll for easy download
  • Fix tooltools typo: Correct the parameter name for shivammathur/setup-php on Ubuntu

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI workflow to improve cross-platform coverage and make Windows build outputs easier to consume, while fixing a configuration typo in the Ubuntu job.

Changes:

  • Fix shivammathur/setup-php input from tool to tools on Ubuntu.
  • Expand the Windows job matrix to test both TS and NTS builds.
  • Upload the built php_mailparse.dll from each Windows matrix entry as a workflow artifact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
@rlerdorf rlerdorf merged commit 3812bb0 into master Apr 5, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants