This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Closed
Conversation
Member
|
Yep, that fix makes sense. com.exe evaluates all variables in a parenthesized |
|
Comment on behalf of cmb at php.net: Applied as bd072f0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@weltling This is a very small change, but it seems that when we
SET PFTT_RELEASE = %PFTT_HOME%\pftt_releasein the middle of the code instead of at the beginning, it doesn't set it right away. Since it isn't set right away, it refers to\bininstead of%PFTT_RELEASE%\bin.This will make the script pack an empty dir instead of the required directories to make pftt run with minimal files.