This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Fixes #59: Updated scripts to tests snapshots better#65
Closed
lavturo wants to merge 2 commits intophp:masterfrom
Closed
Fixes #59: Updated scripts to tests snapshots better#65lavturo wants to merge 2 commits intophp:masterfrom
lavturo wants to merge 2 commits intophp:masterfrom
Conversation
cmb69
suggested changes
Aug 30, 2019
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thanks! Please have a look at my comment below. Otherwise this looks fine.
bin/test_release.cmd
Outdated
| set file_name=php-%branch%-win32-%build%-!cpu[%%j]!-latest | ||
| ) | ||
|
|
||
| call %~dp0pftt.cmd -results_only core_named %PHP_BUILDS%\!file_name! %PHP_BUILDS%\%test_pack% tests\basic\001.phpt |
Member
There was a problem hiding this comment.
This looks like a development relict; should probably be core_list or core_all instead of core_named. Same for the line below.
Contributor
Author
There was a problem hiding this comment.
My bad. Thanks for catching that. Updated!
|
Comment on behalf of cmb at php.net: Thanks! Applied as 1354c8c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cmb69 could you please check?
Changes: