Skip to content

Conversation

derickr
Copy link
Member

@derickr derickr commented Mar 6, 2025

This goes hand in hand with php/web-php#1228 and the changes I pushed to doc-en just now.

derickr added 2 commits March 6, 2025 14:53
This allows us to set 'interactive' annotations on books, sets, and chapters to
signal to the WASM code runner that examples in these areas can be run.

The WASM code runner also checks for the 'non-interactive' annotation and
selectively disables running code for that example.
@derickr derickr requested a review from Girgias March 6, 2025 14:59
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, but I don't know which doc-en changes you are talking about?

@derickr
Copy link
Member Author

derickr commented Mar 6, 2025

That was because my push failed due to a commit by you in between "git pull" and "git commit" - should be there now.

@derickr derickr merged commit b7d8f52 into master Mar 6, 2025
14 checks passed
@Girgias Girgias deleted the interactive-annotation branch March 29, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants