Skip to content

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 7, 2020

A recent commit suppressed the tag formatting of <varname> elements
for Package_PHP_XHTML; this must not be done for <varname>s inside
of <fieldsysnopsis>, though.


The https://www.php.net/manual/en/mysqli.error.php for an example of the currently broken rendering.

A recent commit suppressed the tag formatting of `<varname>` elements
for `Package_PHP_XHTML`; this must not be done for `<varname>`s inside
of `<fieldsysnopsis>`, though.
@cmb69 cmb69 added the bug label Oct 7, 2020
@cmb69 cmb69 requested a review from salathe October 7, 2020 08:11
Copy link
Contributor

@salathe salathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

before and after

@cmb69
Copy link
Member Author

cmb69 commented Oct 7, 2020

Applied as 7624cce.

@cmb69 cmb69 closed this Oct 7, 2020
@cmb69 cmb69 deleted the cmb/varname-fieldsynopsis branch October 7, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants