Skip to content

Conversation

@kocsismate
Copy link
Member

A few examples:

class

class-final

interface

class-extends

class-implements-one

class-implements-many

class-extends-implements

@cmb69
Copy link
Member

cmb69 commented Jul 25, 2021

Using oointerface/interfacename for interfaces is certainly an improvement. I presume that this implementation is good as well, but I think we really should have CI with tests, and extend the testsuite.

@kocsismate
Copy link
Member Author

but I think we really should have CI with tests, and extend the testsuite.

Yeah, I still agree with it, but that would require quite a few additional effort, for which I don't really have the bandwidth. :(

@Girgias Girgias merged commit 29cf251 into php:master Jul 30, 2021
@kocsismate kocsismate deleted the class-interface branch July 30, 2021 14:50
@cmb69
Copy link
Member

cmb69 commented Jul 30, 2021

Seems we need to follow up with manual fixes: :)

Screenshot 2021-07-30 184631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants