spl: deprecate ArrayIterator methods that make little sense

RFC: https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_arrayiterator_methods_that_inherit_arrayobject_implementation

Author: Girgias

ext/spl/spl_array.c

@@ -18,6 +18,7 @@
 
 #include "php.h"
 #include "ext/standard/php_var.h"
+#include "zend_attributes.h"
 #include "zend_smart_str.h"
 #include "zend_interfaces.h"
 #include "zend_exceptions.h"

ext/spl/spl_array.stub.php

@@ -139,60 +139,70 @@ public function count(): int {}
      * @tentative-return-type
      * @implementation-alias ArrayObject::getFlags
      */
+	#[\Deprecated(since: "8.6")]
     public function getFlags(): int {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::setFlags
      */
+	#[\Deprecated(since: "8.6")]
     public function setFlags(int $flags): void {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::asort
      */
+	#[\Deprecated(since: "8.6")]
     public function asort(int $flags = SORT_REGULAR): true {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::ksort
      */
+	#[\Deprecated(since: "8.6")]
     public function ksort(int $flags = SORT_REGULAR): true {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::uasort
      */
+	#[\Deprecated(since: "8.6")]
     public function uasort(callable $callback): true {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::uksort
      */
+	#[\Deprecated(since: "8.6")]
     public function uksort(callable $callback): true {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::natsort
      */
+	#[\Deprecated(since: "8.6")]
     public function natsort(): true {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::natcasesort
      */
+	#[\Deprecated(since: "8.6")]
     public function natcasesort(): true {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::unserialize
      */
+	#[\Deprecated(since: "8.6")]
     public function unserialize(string $data): void {}
 
     /**
      * @tentative-return-type
      * @implementation-alias ArrayObject::serialize
      */
+	#[\Deprecated(since: "8.6")]
     public function serialize(): string {}
 
     /**

ext/spl/spl_array_arginfo.h

@@ -9,7 +9,8 @@ var_dump($arrIter->ksort());
 var_dump($arrIter);
 
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: Method ArrayIterator::ksort() is deprecated since 8.6 in %s on line %d
 bool(true)
 object(ArrayIterator)#1 (1) {
   ["storage":"ArrayIterator":private]=>

ext/spl/tests/ArrayObject/arrayIterator_ksort_basic1.phpt

@@ -21,9 +21,13 @@ int(3)
 
 Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
 int(3)
+
+Deprecated: Method ArrayIterator::getFlags() is deprecated since 8.6 in %s on line %d
 int(3)
 
 Deprecated: ArrayIterator::__construct(): Using an object as a backing array for ArrayIterator is deprecated, as it allows violating class constraints and invariants in %s on line %d
+
+Deprecated: Method ArrayIterator::getFlags() is deprecated since 8.6 in %s on line %d
 int(3)
 
 Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d