PHP_ADD_EXTENSION_DEP doesn't fail when expected (build system)

[dktapps]

Description

I have the following m4 code: https://github.com/pmmp/ext-pmmpthread/blob/6a516e5b58d326e2dcc23bb75fba6e210d5b313f/config.m4#L33-L44

        CLASSES_SRC="classes/pool.c classes/thread.c classes/thread_safe_array.c classes/thread_safe.c classes/runnable.c classes/worker.c"
        PHP_NEW_EXTENSION(pmmpthread, php_pmmpthread.c $CLASSES_SRC src/copy.c src/monitor.c src/worker.c src/globals.c src/prepare.c src/store.c src/handlers.c src/object.c src/routine.c src/queue.c src/ext_sockets_hacks.c, $ext_shared,, -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -Werror=implicit-function-declaration)
        PHP_ADD_BUILD_DIR($ext_builddir/src, 1)
        PHP_ADD_INCLUDE($ext_builddir)

        if test "$PHP_PMMPTHREAD_SOCKETS" != "no"; then
                AC_MSG_NOTICE([Support for passing Socket objects between threads enabled. The sockets extension must be loaded at runtime. You can disable support using --without-pmmpthread-sockets.])
                AC_DEFINE(HAVE_PMMPTHREAD_EXT_SOCKETS_SUPPORT, 1, [Whether pmmpthread supports passing Socket objects between threads])
                PHP_ADD_EXTENSION_DEP(pmmpthread, sockets)
        else
                AC_MSG_NOTICE([Support for passing Socket objects between threads disabled. You can enable support using --with-pmmpthread-sockets.])
        fi
fi

When using --disable-all or --disable-sockets in conjunction with --with-pmmpthread-sockets, I expect the configure command to fail (because of the PHP_ADD_EXTENSION_DEP(pmmpthread, sockets)), but it doesn't.
The build proceeds and results in a compile error due to sockets being disabled.

Similar code for Windows works correctly.

PHP Version

PHP 8.2 git 6a914cb

Operating System

WSL2 Ubuntu 20.04

[petk]

Hello, thanks for bringing this up. It's unfortunate shortcoming of the build system. If you rename the config.m4 to config9.m4 in your extension then it will work. Issue is that these extension directories are parsed alphabetically and sorted by the suffix number in the config{suffix_number}.m4 file. That applies for the extensions that are located in the ext folder. For the phpized extensions this macro doesn't work like that.

You might even want to check something like this when using phpize:

old_CPPFLAGS=$CPPFLAGS
CPPFLAGS="$CPPFLAGS $INCLUDES"
AC_CHECK_DECL([HAVE_SOCKETS],[],[AC_MSG_ERROR([Sockets extension is required])],[[#include "php_config.h"]])
CPPFLAGS=$old_CPPFLAGS

However, I would follow advice about dependencies here: https://www.phpinternalsbook.com/php7/extensions_design/extension_skeleton.html

Hope it helps a bit because I'm not sure yet how to properly resolve this.