For UTF-7, emit error marker if Base64 section ends abruptly after first half of surrogate pair#10927
Closed
alexdowad wants to merge 1 commit intophp:masterfrom
Closed
For UTF-7, emit error marker if Base64 section ends abruptly after first half of surrogate pair#10927alexdowad wants to merge 1 commit intophp:masterfrom
alexdowad wants to merge 1 commit intophp:masterfrom
Conversation
…rst half of surrogate pair This (rare) situation was already handled correctly for the 1st and 2nd of every 3 codepoints in a Base64-encoded section of a UTF-7 string. However, it was not handled correctly if it happened on the 3rd, 6th, 9th, etc. codepoint of such a Base64-encoded section.
Girgias
approved these changes
Mar 26, 2023
Contributor
Author
|
Looks like this is already handled correctly for UTF7-IMAP. |
Contributor
Author
|
Landed on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (rare) situation was already handled correctly for the 1st and 2nd of every 3 codepoints in a Base64-encoded section of a UTF-7 string. However, it was not handled correctly if it happened on the 3rd, 6th, 9th, etc. codepoint of such a Base64-encoded section.
This was discovered while fuzzing @pakutoma's recent PR, which introduced new validation logic for ISO-2022-JP, JIS, and UTF-7.
@cmb69 @Girgias @kamil-tekiela @youkidearitai