Fix various bugs related to DNF types #11973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Aug 15, 2023
Zend/zend_inheritance.c
Outdated
| static void zend_type_copy_ctor(zend_type *type, bool use_arena, bool persistent); | ||
|
|
||
| static void zend_type_list_copy_ctor( | ||
| zend_type *const global_type, |
Member
There was a problem hiding this comment.
parent_type? Or maybe list_type. Global type sounds like it's the root element.
Zend/zend_inheritance.c
Outdated
| ZEND_ASSERT(ZEND_TYPE_HAS_NAME(*list_type)); | ||
| zend_string_addref(ZEND_TYPE_NAME(*list_type)); | ||
| } ZEND_TYPE_LIST_FOREACH_END(); | ||
| zend_type_list_copy_ctor(type, ZEND_TYPE_LIST(*type), use_arena, persistent); |
Member
There was a problem hiding this comment.
Nit: No reason to pass ZEND_TYPE_LIST(*type) instead of accessing it from the function.
Member
Author
There was a problem hiding this comment.
Ah right, that's a remnant from an earlier iteration of the function
- phpGH-11958: DNF types in trait properties do not get bound properly - phpGH-11883: Memory leak in zend_type_release() for non-arena allocated DNF types - Internal trait bound to userland class would not be arena allocated - Property DNF types were not properly deep copied during lazy loading Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com> Co-authored-by: ju1ius <jules.bernable@gmail.com>
Girgias
force-pushed
the
dnf-types-bugfixes
branch
from
34d2cf9 to
02a80c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend_type_release#11883: Memory leak in zend_type_release() for non-arena allocated DNF types