Skip to content

Prevents double-call to internal iterators rewind handler #12061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Prevents double-call to internal iterators rewind handler #12061

wants to merge 2 commits into from

Conversation

@ju1ius
Copy link
Contributor

@ju1ius ju1ius commented Aug 27, 2023 •
edited
Loading

Closes #12060

@ju1ius ju1ius force-pushed the ju1ius/internal-iterator-rewind branch 2 times, most recently from 5c5def8 to ebe62bf Compare August 27, 2023 17:12
iluuu1994
iluuu1994 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look reasonable, thank you @ju1ius!

Girgias
Girgias reviewed Aug 30, 2023
View reviewed changes
@ju1ius ju1ius force-pushed the ju1ius/internal-iterator-rewind branch from ebe62bf to f6f9cba Compare September 2, 2023 03:17
@Girgias
Copy link
Member

Girgias commented Sep 2, 2023

Is this bug present in 8.1 or 8.2? In which case it would make sense to backport this. :)

@ju1ius
Copy link
Contributor Author

ju1ius commented Sep 2, 2023

Is this bug present in 8.1 or 8.2? In which case it would make sense to backport this. :)

At a first glance, it looks like this class was introduced - along with this bug - in 8.0.

@Girgias
Copy link
Member

Girgias commented Sep 2, 2023

Is this bug present in 8.1 or 8.2? In which case it would make sense to backport this. :)

At a first glance, it looks like this class was introduced - along with this bug - in 8.0.

Could you rebase this onto 8.1 then?

@ju1ius ju1ius force-pushed the ju1ius/internal-iterator-rewind branch from f6f9cba to 9c3e901 Compare September 5, 2023 00:46
@ju1ius ju1ius changed the base branch from master to PHP-8.1 September 5, 2023 00:47
@ju1ius
Copy link
Contributor Author

ju1ius commented Sep 5, 2023 •
edited
Loading

Could you rebase this onto 8.1 then?

@Girgias Done!

@ju1ius ju1ius force-pushed the ju1ius/internal-iterator-rewind branch from 9c3e901 to 4005834 Compare September 5, 2023 00:51
@Girgias
Copy link
Member

Girgias commented Sep 5, 2023

Merged as da7a66d

@Girgias Girgias closed this Sep 5, 2023
@ju1ius
Copy link
Contributor Author

ju1ius commented Sep 5, 2023

Merged as da7a66d

You don't like unit tests? 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@Girgias Girgias Girgias left review comments

@kocsismate kocsismate Awaiting requested review from kocsismate

Assignees

No one assigned

Labels

Category: Build System Category: Engine Extension: zend_test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

internal iterator rewind handler is called twice

3 participants

@ju1ius @Girgias @iluuu1994