Fix: Colon in url path is not parsed by parse_url

[vdauchy]

This aims to solve #12703

Note: This is my first PR to php-src, could you clarify how the test file shall be named (temporarily named bugX.phpt ) ?

[jorgsowa]

Hey!
You can add the number of Github Issue insetad of X, as was done i.e. https://github.com/php/php-src/pull/12679/files

So for your case would be gh12703.phpt.

Edit: sorry for previous confusion.

[ndossche]

Also: for bugs on the github bugtracker the filename should start with gh instead of bug. And the title "GH-..." instead of "Bug #..."

[bukka]

Just to clarify, the bug prefix is for bugs in old bug tracker. For GitHub issue, we use gh prefix. So the test name should be gh12703.phpt

[ndossche]

Gah I mixed the two somehow in my answer, sorry, edited to be correct now.

[nicolas-grekas]

Should this target 8.1?

[vdauchy]

• Test file's name and title corrected. @bukka

@nicolas-grekas I don't know... I will happily re-do a PR to a lower branch if that's required...

[iluuu1994]

Related: #7890 (comment)

Changes in the parser are risky, because people use them on invalid URLs. Thus, it's very hard to predict what side-effects a change has. Obviously we should prioritize parsing of valid URLs, but it might be better to be prudent and merge this for master only.

[vdauchy]

Thanks for your comment @iluuu1994, I added an example for context (the case where query params are given) and the cases from the issue you referenced (which this PR solves 😃).

[vdauchy]

Hello @bukka , I was wondering if they would be any follow up / merge of this PR or is it any thing else I shall do ?

[vdauchy]

Closing following RFC: https://wiki.php.net/rfc/url_parsing_api