Use strtoll() and atoll() unconditionally #13658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
reviewed
Mar 18, 2024
Member
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
IMO, it doesn't hurt to keep these tests so I'm -0.5 on this.
You never know what kind of weird platform claims to support C99, but then doesn't.
Member
Author
|
There are such *nix platforms indeed. If they don't have these then you can safely bet that the PHP-8.4-dev definitely won't compile on those. They are mostly locked machines that don't receive any updates anymore. And we definitely shouldn't support such machines. These are already used unconditionally in all of php-src. I think there is very little sense in checking these in ext/date specifically. It makes two tests less. |
Member
Author
|
Well, this can also wait for PHP-9 with this if you're concerned. |
The strtoll() and atoll() are C99 standard functions [1] and don't need checking. Since the upstream timelib library needs to be changed separately, this simplifies checking by using a compile definition. [1]: https://port70.net/~nsz/c/c99/n1256.html#7.20.1.2
petk
force-pushed
the
patch-strtoll-atoll
branch
from
c34b5e1 to
84c57b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strtoll() and atoll() are C99 standard functions and don't need checking. Since the upstream timelib library needs to be changed separately, this simplifies checking by using a compile definition.