Implement namedItem() and equivalent dimension handlers for HTMLCollection #13937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
force-pushed
the
dom-named-item
branch
from
ce3dd62 to
96397ae
Compare
Girgias
approved these changes
Apr 14, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Mostly looks good to me, minor comments.
ext/dom/tests/modern/html/interactions/HTMLCollection_named_reads.phpt
Outdated
Show resolved
Hide resolved
ext/dom/tests/modern/html/interactions/HTMLCollection_named_reads.phpt
Outdated
Show resolved
Hide resolved
ndossche
force-pushed
the
dom-named-item
branch
from
96397ae to
132fd6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was left out of the initial implementation of the DOM spec RFC PR because that one was big enough already.
This implements the only missing method of the HTMLCollection class that was added in that RFC.
For reviewing: please see individual commits.