Skip to content

Conversation

@petk
Copy link
Member

@petk petk commented May 21, 2024

This adds libxml as a dependency to ext/soap.

@petk
Copy link
Member Author

petk commented May 21, 2024

There is also another issue in awk which is not filtering the Autoconf quotes... I'll recheck this.

This adds the libxml extension to required dependencies for ext/soap
during the configuration phase (PHP_ADD_EXTENSION_DEP) and the runtime
(ZEND_MOD_REQUIRED).
@petk petk force-pushed the patch-soap-dependencies branch from 22fd972 to 2fdb553 Compare May 21, 2024 09:39
@petk petk marked this pull request as ready for review May 21, 2024 09:40
@petk
Copy link
Member Author

petk commented May 21, 2024

About the awk issue not filtering quotes PHP_ADD_EXTENSION_DEP([soap], [libxml]), I'll just add unquoted arguments here as done in other extensions and perhaps open a separate PR for the awk fix. So this is ready now.

@Girgias Girgias requested a review from ndossche May 21, 2024 11:29
@petk petk merged commit 02f3df1 into php:master May 21, 2024
@petk petk deleted the patch-soap-dependencies branch May 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants