Skip to content

nit: bool "must" be used instead. #14287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iluuu1994 merged 1 commit into from
May 21, 2024
Merged

nit: bool "must" be used instead. #14287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/tests/type_declarations/union_types/redundant_types/bool_instead_false_and_true.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ function test(): false|true {

?>
--EXPECTF--
Fatal error: Type contains both true and false, bool should be used instead in %s on line %d
Fatal error: Type contains both true and false, bool must be used instead in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/type_declarations/union_types/redundant_types/bool_instead_true_and_false.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ function test(): true|false {

?>
--EXPECTF--
Fatal error: Type contains both true and false, bool should be used instead in %s on line %d
Fatal error: Type contains both true and false, bool must be used instead in %s on line %d
2 changes: 1 addition & 1 deletion Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6852,7 +6852,7 @@ static zend_type zend_compile_typename_ex(
if ( ((type_mask & MAY_BE_TRUE) && (single_type_mask == MAY_BE_FALSE))
|| ((type_mask & MAY_BE_FALSE) && (single_type_mask == MAY_BE_TRUE)) ) {
zend_error_noreturn(E_COMPILE_ERROR,
"Type contains both true and false, bool should be used instead");
"Type contains both true and false, bool must be used instead");
}
ZEND_TYPE_FULL_MASK(type) |= ZEND_TYPE_PURE_MASK(single_type);
ZEND_TYPE_FULL_MASK(single_type) &= ~_ZEND_TYPE_MAY_BE_MASK;
Expand Down