Fixed GH-14383: Fixed usec was carry up #14463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If round to the fractional part of a timestamp, a carry will occur in cases such as 999 999 9. In that case, set usec to 0 and add 1 to sec.
SakiTakamachi
force-pushed
the
fix/gh-14383
branch
from
a8b8a69 to
0e16bd9
Compare
mvorisek
reviewed
Jun 4, 2024
SakiTakamachi
changed the title
SakiTakamachi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If round the fractional part of a timestamp to 6 digits, a carry will occur in cases such as .999_999_9 to .100_000. In that case, set usec to 0 and add 1 to sec.
fixes #14383
Since this is an unreleased feature, I don't think it is necessary to update the NEWS entry. How do you think?