Fix sign conversion warnings, part 3 #14472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested review from
adoy,
alexdowad,
bukka,
devnexen and
ndossche
as code owners
Girgias
force-pushed
the
fix-sign-conversions3
branch
2 times, most recently
from
4bc94d3 to
d0e68fe
Compare
devnexen
reviewed
Jun 5, 2024
sapi/fpm/fpm/fpm_scoreboard.c
Outdated
| mem += scoreboard_size; | ||
|
|
||
| for (i = 0; i < scoreboard->nprocs; i++, mem += sizeof(struct fpm_scoreboard_proc_s)) { | ||
| for (unsigned int i = 0; i < scoreboard->nprocs; i++, mem += sizeof(struct fpm_scoreboard_proc_s)) { |
Member
There was a problem hiding this comment.
Note: since you changed here ... fpm_scoreboard_proc_acquire takes a signed int.
devnexen
reviewed
Jun 5, 2024
sapi/fpm/fpm/fpm_status.c
Outdated
| struct timeval duration, now; | ||
| double cpu; | ||
| int i; | ||
| unsigned int i; |
ndossche
approved these changes
Jun 5, 2024
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Ack for zend_test, dom, fileinfo
alexdowad
approved these changes
Jun 6, 2024
Contributor
alexdowad
left a comment
alexdowad
left a comment
There was a problem hiding this comment.
I don't see anything which I believe could possibly cause a problem with mbstring.
This does unnecessary conversions
Girgias
force-pushed
the
fix-sign-conversions3
branch
from
d0e68fe to
d71456d
Compare
Member
Author
|
I am splitting the FPM changes to a different PR for the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14448
MBString is going to be tricky to get warning free, as I don't necessarily understand everything what is happening, but the ones in this PR should be safe. However, I will likely add the
-Wno-sign-comparewarning to the extension CFLAGS to let someone else deal with those issues long term.