Fix sign conversion warnings, part 1 #14448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
fix-sign-conversions1
branch
from
cd59613 to
aae2605
Compare
Girgias
requested review from
TimWolla,
bukka,
derickr,
dstogov,
iluuu1994 and
zeriyoshi
as code owners
Member
|
Probably, this makes sense. (I didn't check all the changes). |
zeriyoshi
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to go back to one of my old long term projects, which is to enable the
-Wsign-comparewarning, which is currently suppressed inZend.m4.I have an old branch that I rebased, however I have lost track of what is related or not to changes I made during the lifespan of that branch, and there are a lot of changes. So I am extracting some of the more immediate changes into smaller PRs.