Unify types of PHP_VERSION and friends on Windows #16247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `phpize` builds, all three version variables are numbers, but for `buildconf` builds, all are strings. This can yield surprising results when extensions create their `PHP_VERSION_ID` like 10000 * PHP_VERSION + 100 * PHP_MINOR_VERSION + PHP_RELEASE_VERSION Since `phpize` builds are way more common for external extensions nowadays, we change the types for `buildconf` builds.
|
Makes sense to me |
|
The |
Girgias
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
phpizebuilds, all three version variables are numbers, but forbuildconfbuilds, all are strings. This can yield surprising results when extensions create theirPHP_VERSION_IDlike10000 * PHP_VERSION + 100 * PHP_MINOR_VERSION + PHP_RELEASE_VERSION
Since
phpizebuilds are way more common for external extensions nowadays, we change the types forbuildconfbuilds.